fix missing condition declaration #29
Closed
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I'll try this out, and I'll also try it on the legacy branch. The tests are full program runs, and are executed over on gitlab at the moment, only. Currently there are 300 or so cases. I'll need to add some new ones to cover this bug too. |
GrahamCampbell
added a commit
that referenced
this pull request
Jul 3, 2020
Closes #10. Closes #29. Co-Authored-By: rsoeldner <[email protected]>
|
I've confirmed this fixes the issue now too, adding the tests as detailed in: https://gitlab.com/YorkCS/Batman/Tests/-/commit/e30d48f5dbb4ec38570a016cce08f9b2c8f7930b. I've merged your changes and re-triggered the build and test, including the test runs with valgrind: |
|
https://gp2.gjcampbell.co.uk/ is now running the latest version. |
|
NB There still seem to be problems with nested conditions: #30. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this should fix #10, unfortunately, I was not able to identify a test-suite, would appreciate verifying, it breaks nothing :-)