[pull] master from Roblox:master #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…tions-manual Update GHA non-cached third party actions
Pull Request Test Coverage Report for Build 1901845442
💛 - Coveralls |
…location in the Roblox org on GitHub (#68) This batch change updates the reference to the setup-foreman action to use the current location of the action in the Roblox org. This should be a no-op, or may fix currently-broken CI. Please refer to confluence for more information. Created by Sourcegraph batch change pdoyle/migrate-setup-foreman-action.
This feature is equivalent to what is available in newer versions of Redux: https://github.com/reduxjs/redux-thunk#injecting-a-custom-argument It allows arbitrary parameters to injected into thunks via a table passed in at Rodux initialization time (useful for passing in services or anything else we might want to mock for tests). It can replace other custom middlewares we've written to achieve the same thing (e.g. PaginatedFetchThunk.middleware, AvatarEditorServiceThunk.middleware, RNAdapterThunk.middleware)
Adds Luau types for actions and reducers, directly inspired by upstream Redux types.
Follows up on the types added in: #70. Adds Luau types for thunks and the store. This is partially inspired by upstream Redux types here and here, but modified to be as useful as possible given Luau's constraints.
luau-analyze was deprecated in favor of using luau-lsp analyze
* Add fix for broken test * bump tools, address changes
This PR makes some improvements to the existing Luau types, including: Improves reuse of the Action type Fixes contravariance issue with Store type Allows thunks to be void returning
Moves Signal connect() and disconnect() tracebacks under a dev flag. The remaining debug.traceback() calls will all immediately throw an error, so there's no point in calling them conditionally.
EECI-4699: Update CLA Signature Bot
Co-authored-by: Paul Doyle <[email protected]>
#flagged - Add Flag around disabling connection callbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )