New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly export exported symbols, hide the rest #115

Open

mrdomino wants to merge 5 commits into UpstandingHackers:master from mrdomino:h-export

mrdomino commented Dec 12, 2014

Builds and links. Only results in a 1k reduction in the shared lib, but probably still worth it for external-API-documentation reasons.

Steven Dee added 5 commits

December 11, 2014 22:12


          Add visibility declarations

17eb4d5


          Add export.h to build and other stuff

48a5032


          Remove trailing whitespace

4596ec6


          also export allocator.h

391958e

+ ifndef guard on export.h


          Fix comment

cf7fbcb

Author

mrdomino commented Dec 12, 2014

Blargh, internal symbols breaking the tests. Options:

Export the internal symbols
Make the tests not use the internal symbols
Make the tests link against special objects for the internal symbols

Dunno at this point which is least sucky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet