Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SConstruct for darwin. #188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

schulze
Copy link

@schulze schulze commented Feb 5, 2018

This fixes the build to respect CC=gcc on darwin and to ignore a
warning that breaks the build with xcodes's clang on my system.

This fixes the build to respect CC=gcc on darwin and to ignore a
warning that breaks the build with xcodes's clang on my system.
@prashantbarca
Copy link

@schulze -Wno-unknown-pragmas sufficed for me to get it to work with clang!

@schulze
Copy link
Author

schulze commented Feb 6, 2018

@prashantbarca -Wno-unknown-pragmas does not suffice on this system:

clang -o build/opt/src/backends/regex.os -c -std=gnu99 -Wall -Wextra -Werror -Wno-unused-parameter -Wno-attributes -Wno-unused-variable -Wno-unknown-pragmas -O3 -fPIC 
build/opt/src/backends/regex.c
build/opt/src/backends/regex.c:229:32: error: unknown warning group '-Wclobbered', ignored
  [-Werror,-Wunknown-warning-option]
#pragma GCC diagnostic ignored "-Wclobbered"
                           ^
1 error generated.

Mac OS X is not my native habitat, so it might well be that I am missing something here. Xcode should be up to date.

@schulze
Copy link
Author

schulze commented Feb 6, 2018

As the error message say, the problem here is not a unknown pragma, but the unknown warning that is introduced by the pragma.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants