New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding output formatters #20

Merged

stuartlynn merged 13 commits into main from formatters

May 22, 2024

Contributor

stuartlynn commented May 10, 2024 •

edited

Loading

This PR adds

A trait and enum for different output formats. This gives us save and format functions to take the data request result and turn it in to either a string or a written file.
Implementations of this format for CSV output format
Code that invokes the CSV formatter as part of the data request

TODO

stuartlynn added 7 commits

May 10, 2024 13:49


          CSV output formatter working

38a076e


          Geojson properties now serialzing properly

30a9f74


          GeoJsonSeq formater

1278f1e


          Tests

1a4447a


          Clippy suggestions

0eacbf9


          WKB formatting for CSVs

903d92a


          Tidying up test

stuartlynn changed the title ~~WIP: Adding output formatters~~ Adding output formatters

stuartlynn requested a review from yongrenjie

May 16, 2024 11:02

stuartlynn added 2 commits

May 16, 2024 12:58


          Merge branch 'main' into formatters

626ee06


          Fix after merge

sgreenbury reviewed

View reviewed changes

src/formatters.rs Outdated Show resolved Hide resolved

sgreenbury reviewed

View reviewed changes

src/formatters.rs Outdated Show resolved Hide resolved

sgreenbury reviewed

View reviewed changes

src/formatters.rs Outdated Show resolved Hide resolved

sgreenbury reviewed

View reviewed changes

src/formatters.rs Show resolved Hide resolved

sgreenbury reviewed

View reviewed changes

src/lib.rs Show resolved Hide resolved

sgreenbury reviewed

View reviewed changes

src/formatters.rs Outdated Show resolved Hide resolved

Contributor

sgreenbury commented May 21, 2024

Looks great! Just left a few small comments/suggestions in the code including some that would be better as new issues rather than changed here if implemented.

stuartlynn and others added 4 commits

May 22, 2024 11:41


          Update src/formatters.rs

fdaf676

Avoid unwrap by mapping error

Co-authored-by: Sam Greenbury <[email protected]>


          Update src/formatters.rs

ac932c1

Co-authored-by: Sam Greenbury <[email protected]>


          Update src/formatters.rs

83a9301

Co-authored-by: Sam Greenbury <[email protected]>


          Mapping error instead of unwrap

7c925cb

Contributor Author

stuartlynn commented May 22, 2024

Thanks @sgreenbury merging this in

stuartlynn merged commit 9ea552e into main

1 check passed

stuartlynn mentioned this pull request

Write write a function to write the results to a number of different formats #7

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet