YDA-5953 uuUserExists with rule_user_exists #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FuHsinyu
commented
Oct 2, 2024
stsnel
reviewed
Oct 3, 2024
There was a problem hiding this comment.
This looks good to me in general 👍
Can we move the code to retrieve the client_hints and select the right rule name to the constructor of RuleInterface? In that case we have to request client hints only once, rather than invoking this API endpoint for every rule invocation (which would double the number of API calls for checking whether users already exist).
|
@stsnel I have updated the codes based on your suggestions. |
stsnel
reviewed
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rule_interface.call_rule_user_exists(user)for either case of rule_user_exists and uuUserExists. (running make and make install are required to update the rule base)