Sunset intake module 🫡 #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwesterhof
force-pushed
the
sunset-intake
branch
from
63d402e
to
6e054d0
Compare
This was referenced Nov 5, 2024
stsnel
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Please consider also removing these files:
-docs/design/overview/intake.md
-roles/yoda_rulesets/files/run-intake-movetovault.sh
-roles/yoda_test/files/intake_testset_initial (as well as tasks referring to it in roles/yoda_test/tasks/install-data.yml)
LGTM for the rest 👍 !
Thanks! |
lwesterhof
force-pushed
the
sunset-intake
branch
from
6e054d0
to
24b024c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These PRs sunset the intake module while ensuring backwards compatibility for intake- and grp- groups in the group manager. Users can still manage and view existing intake- and grp- groups in the research space, but new groups of these types cannot be created.
UtrechtUniversity/yoda-portal#373
UtrechtUniversity/yoda-ruleset#532