Save Changes & Submit

VCA-EPFL · Feb 29, 2024 · e4b5146 · e4b5146
1 parent f889391
commit e4b5146
Show file tree

Hide file tree

Showing 23 changed files with 27 additions and 27 deletions.
diff --git a/part_1_combinational/AluTest b/part_1_combinational/AluTest
@@ -9,4 +9,4 @@ do
     exec $BLUESPECDIR/tcllib/bluespec/bluesim.tcl $0.so mkTest --script_name `basename $0` -h
   fi
 done
-exec $BLUESPECDIR/tcllib/bluespec/bluesim.tcl $0.so mkTest --script_name `basename $0` --creation_time 1708704119 "$@"
+exec $BLUESPECDIR/tcllib/bluespec/bluesim.tcl $0.so mkTest --script_name `basename $0` --creation_time 1709227451 "$@"
diff --git a/part_1_combinational/AluTest.so b/part_1_combinational/AluTest.so
diff --git a/part_1_combinational/ArbiterTest b/part_1_combinational/ArbiterTest
@@ -9,4 +9,4 @@ do
     exec $BLUESPECDIR/tcllib/bluespec/bluesim.tcl $0.so mkTest --script_name `basename $0` -h
   fi
 done
-exec $BLUESPECDIR/tcllib/bluespec/bluesim.tcl $0.so mkTest --script_name `basename $0` --creation_time 1708704122 "$@"
+exec $BLUESPECDIR/tcllib/bluespec/bluesim.tcl $0.so mkTest --script_name `basename $0` --creation_time 1709227454 "$@"
diff --git a/part_1_combinational/ArbiterTest.so b/part_1_combinational/ArbiterTest.so
diff --git a/part_1_combinational/ShifterTest b/part_1_combinational/ShifterTest
@@ -9,4 +9,4 @@ do
     exec $BLUESPECDIR/tcllib/bluespec/bluesim.tcl $0.so mkTest --script_name `basename $0` -h
   fi
 done
-exec $BLUESPECDIR/tcllib/bluespec/bluesim.tcl $0.so mkTest --script_name `basename $0` --creation_time 1708704126 "$@"
+exec $BLUESPECDIR/tcllib/bluespec/bluesim.tcl $0.so mkTest --script_name `basename $0` --creation_time 1709227458 "$@"
diff --git a/part_1_combinational/ShifterTest.so b/part_1_combinational/ShifterTest.so
diff --git a/part_1_combinational/build/mkTest.cxx b/part_1_combinational/build/mkTest.cxx
@@ -1,7 +1,7 @@
 /*
  * Generated by Bluespec Compiler, version 2023.07 (build 0eb551d)
  * 
- * On Fri Feb 23 17:02:06 CET 2024
+ * On Thu Feb 29 18:24:18 CET 2024
  * 
  */
 #include "bluesim_primitives.h"

diff --git a/part_1_combinational/build/mkTest.h b/part_1_combinational/build/mkTest.h
@@ -1,7 +1,7 @@
 /*
  * Generated by Bluespec Compiler, version 2023.07 (build 0eb551d)
  * 
- * On Fri Feb 23 17:02:06 CET 2024
+ * On Thu Feb 29 18:24:18 CET 2024
  * 
  */
 

diff --git a/part_1_combinational/build/model_mkTest.cxx b/part_1_combinational/build/model_mkTest.cxx
@@ -1,7 +1,7 @@
 /*
  * Generated by Bluespec Compiler, version 2023.07 (build 0eb551d)
  * 
- * On Fri Feb 23 17:02:06 CET 2024
+ * On Thu Feb 29 18:24:18 CET 2024
  * 
  */
 #include "bluesim_primitives.h"
@@ -212,8 +212,8 @@ void MODEL_mkTest::get_version(char const **name, char const **build)
 time_t MODEL_mkTest::get_creation_time()
 {
 
-  /* Fri Feb 23 16:02:06 UTC 2024 */
-  return 1708704126llu;
+  /* Thu Feb 29 17:24:18 UTC 2024 */
+  return 1709227458llu;
 }
 
 /* State dumping function */

diff --git a/part_1_combinational/build/model_mkTest.h b/part_1_combinational/build/model_mkTest.h
@@ -1,7 +1,7 @@
 /*
  * Generated by Bluespec Compiler, version 2023.07 (build 0eb551d)
  * 
- * On Fri Feb 23 17:02:06 CET 2024
+ * On Thu Feb 29 18:24:18 CET 2024
  * 
  */
 

diff --git a/part_1_combinational/build/model_mkTest.o b/part_1_combinational/build/model_mkTest.o
diff --git a/part_1_combinational/build/module_naiveShfl.cxx b/part_1_combinational/build/module_naiveShfl.cxx
@@ -1,7 +1,7 @@
 /*
  * Generated by Bluespec Compiler, version 2023.07 (build 0eb551d)
  * 
- * On Fri Feb 23 17:02:06 CET 2024
+ * On Thu Feb 29 18:24:18 CET 2024
  * 
  */
 #include "bluesim_primitives.h"

diff --git a/part_1_combinational/build/module_naiveShfl.h b/part_1_combinational/build/module_naiveShfl.h
@@ -1,7 +1,7 @@
 /*
  * Generated by Bluespec Compiler, version 2023.07 (build 0eb551d)
  * 
- * On Fri Feb 23 17:02:06 CET 2024
+ * On Thu Feb 29 18:24:18 CET 2024
  * 
  */
 

diff --git a/part_2_vector_multiply/TbVD b/part_2_vector_multiply/TbVD
@@ -9,4 +9,4 @@ do
     exec $BLUESPECDIR/tcllib/bluespec/bluesim.tcl $0.so mkTb --script_name `basename $0` -h
   fi
 done
-exec $BLUESPECDIR/tcllib/bluespec/bluesim.tcl $0.so mkTb --script_name `basename $0` --creation_time 1708704131 "$@"
+exec $BLUESPECDIR/tcllib/bluespec/bluesim.tcl $0.so mkTb --script_name `basename $0` --creation_time 1709227463 "$@"
diff --git a/part_2_vector_multiply/TbVD.so b/part_2_vector_multiply/TbVD.so
diff --git a/part_2_vector_multiply/VectorDot.bsv b/part_2_vector_multiply/VectorDot.bsv
@@ -42,7 +42,7 @@ module mkVectorDot (VD);
                             address: zeroExtend(pos_a),
                             datain: ?});
 
-        if (pos_a < dim*zeroExtend(i+1)-1)
+        if (pos_a < dim*zeroExtend(i+1)-1) // BUG 1: position starts from dim*i and goes until dim*i+dim-1
             pos_a <= pos_a + 1;
         else done_a <= True;
 
@@ -56,7 +56,7 @@ module mkVectorDot (VD);
                 address: zeroExtend(pos_b),
                 datain: ?});
 
-        if (pos_b < dim*zeroExtend(i+1)-1)
+        if (pos_b < dim*zeroExtend(i+1)-1) // BUG 2: position starts from dim*i and goes until dim*i+dim-1
             pos_b <= pos_b + 1;
         else done_b <= True;
 
@@ -67,7 +67,7 @@ module mkVectorDot (VD);
         let out_a <- a.portA.response.get();
         let out_b <- b.portA.response.get();
 
-        output_res <=  output_res + out_a*out_b;     
+        output_res <=  output_res + out_a*out_b;   // BUG 3: Multiplication should accumulate  
         pos_out <= pos_out + 1;
 
         if (pos_out == dim-1) begin
@@ -83,19 +83,19 @@ module mkVectorDot (VD);
 
     method Action start(Bit#(8) dim_in, Bit#(2) i_in) if (!ready_start);
         ready_start <= True;
-        output_res <= 0;
+        output_res <= 0; // BUG 4: Output should be cleared for the process
         dim <= dim_in;
         done_all <= False;
-        pos_a <= dim_in*zeroExtend(i_in);
-        pos_b <= dim_in*zeroExtend(i_in);
+        pos_a <= dim_in*zeroExtend(i_in); // BUG 5: Variable 'i' refers to the old value of the register, 'i_in' should be the correct value
+        pos_b <= dim_in*zeroExtend(i_in); // BUG 6: Variable 'i' refers to the old value of the register, 'i_in' should be the correct value
         done_a <= False;
         done_b <= False;
         pos_out <= 0;
         i <= i_in;
     endmethod
 
     method ActionValue#(Bit#(32)) response() if (done_all);
-        ready_start <= False;
+        ready_start <= False; // BUG 7: To start the 'ready_start' value should be false, so when the response is read it can be set to false
         return output_res;
     endmethod
 

diff --git a/part_2_vector_multiply/build/mkTb.cxx b/part_2_vector_multiply/build/mkTb.cxx
@@ -1,7 +1,7 @@
 /*
  * Generated by Bluespec Compiler, version 2023.07 (build 0eb551d)
  * 
- * On Fri Feb 23 17:02:11 CET 2024
+ * On Thu Feb 29 18:24:23 CET 2024
  * 
  */
 #include "bluesim_primitives.h"

diff --git a/part_2_vector_multiply/build/mkTb.h b/part_2_vector_multiply/build/mkTb.h
@@ -1,7 +1,7 @@
 /*
  * Generated by Bluespec Compiler, version 2023.07 (build 0eb551d)
  * 
- * On Fri Feb 23 17:02:11 CET 2024
+ * On Thu Feb 29 18:24:23 CET 2024
  * 
  */
 

diff --git a/part_2_vector_multiply/build/mkVectorDot.cxx b/part_2_vector_multiply/build/mkVectorDot.cxx
@@ -1,7 +1,7 @@
 /*
  * Generated by Bluespec Compiler, version 2023.07 (build 0eb551d)
  * 
- * On Fri Feb 23 17:02:11 CET 2024
+ * On Thu Feb 29 18:24:23 CET 2024
  * 
  */
 #include "bluesim_primitives.h"

diff --git a/part_2_vector_multiply/build/mkVectorDot.h b/part_2_vector_multiply/build/mkVectorDot.h
@@ -1,7 +1,7 @@
 /*
  * Generated by Bluespec Compiler, version 2023.07 (build 0eb551d)
  * 
- * On Fri Feb 23 17:02:11 CET 2024
+ * On Thu Feb 29 18:24:23 CET 2024
  * 
  */
 

diff --git a/part_2_vector_multiply/build/model_mkTb.cxx b/part_2_vector_multiply/build/model_mkTb.cxx
@@ -1,7 +1,7 @@
 /*
  * Generated by Bluespec Compiler, version 2023.07 (build 0eb551d)
  * 
- * On Fri Feb 23 17:02:11 CET 2024
+ * On Thu Feb 29 18:24:23 CET 2024
  * 
  */
 #include "bluesim_primitives.h"
@@ -312,8 +312,8 @@ void MODEL_mkTb::get_version(char const **name, char const **build)
 time_t MODEL_mkTb::get_creation_time()
 {
 
-  /* Fri Feb 23 16:02:11 UTC 2024 */
-  return 1708704131llu;
+  /* Thu Feb 29 17:24:23 UTC 2024 */
+  return 1709227463llu;
 }
 
 /* State dumping function */

diff --git a/part_2_vector_multiply/build/model_mkTb.h b/part_2_vector_multiply/build/model_mkTb.h
@@ -1,7 +1,7 @@
 /*
  * Generated by Bluespec Compiler, version 2023.07 (build 0eb551d)
  * 
- * On Fri Feb 23 17:02:11 CET 2024
+ * On Thu Feb 29 18:24:23 CET 2024
  * 
  */
 

diff --git a/part_2_vector_multiply/build/model_mkTb.o b/part_2_vector_multiply/build/model_mkTb.o