User dataset tweaks (#1261)

* max height for SelectTree popup 40em * handle case where fileListing is undefined * Update verbiage
VEuPathDB · Nov 5, 2024 · e8dc14d · e8dc14d
1 parent 5dce817
commit e8dc14d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/packages/libs/coreui/src/components/inputs/SelectTree/SelectTree.tsx b/packages/libs/coreui/src/components/inputs/SelectTree/SelectTree.tsx
@@ -85,7 +85,11 @@ function SelectTree<T>(props: SelectTreeProps<T>) {
       isDisabled={props.isDisabled}
     >
       <div
-        style={{ padding: '.5em .5em .5em 0', width: '30em', height: '60vh' }}
+        style={{
+          padding: '1em 1em 1em .5em',
+          width: '30em',
+          height: 'min(60vh, 40em)',
+        }}
       >
         {wrapPopover ? wrapPopover(checkboxTree) : checkboxTree}
       </div>

diff --git a/packages/libs/user-datasets/src/lib/Components/Detail/BigwigDatasetDetail.jsx b/packages/libs/user-datasets/src/lib/Components/Detail/BigwigDatasetDetail.jsx
@@ -108,7 +108,7 @@ class BigwigDatasetDetail extends UserDatasetDetail {
   renderTracksSection() {
     const { userDataset, appUrl, projectName, config, fileListing } =
       this.props;
-    const installFiles = fileListing.install?.contents
+    const installFiles = fileListing?.install?.contents
       ?.filter((file) => file.fileName.endsWith('.bw'))
       .map((file) => ({
         dataFileName: file.fileName,

diff --git a/packages/libs/web-common/src/user-dataset-upload-config.tsx b/packages/libs/web-common/src/user-dataset-upload-config.tsx
@@ -56,7 +56,7 @@ export const uploadTypeConfig: DatasetUploadTypeConfig<ImplementedUploadTypes> =
             <br />
             <br />
             The files must be mapped to the reference genome that you select
-            below.
+            above.
             <br />
             Only letters, numbers, spaces and dashes are allowed in the file
             name.
@@ -110,7 +110,7 @@ export const uploadTypeConfig: DatasetUploadTypeConfig<ImplementedUploadTypes> =
             .
             <br />
             The bigwig files you select here must be mapped to the reference
-            genome that you select below.
+            genome that you select above.
             <br />
             Only letters, numbers, spaces and dashes are allowed in the file
             name.
@@ -301,6 +301,7 @@ function ReferenceGenomeDepdency(props: DependencyProps) {
   if (organismTree == null) return null;
   return (
     <SelectTree
+      shouldCloseOnSelection
       buttonDisplayContent="Choose reference genome"
       tree={organismTree}
       getNodeId={getNodeId}