-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to highlight points to scatterplot #1328
Open
asizemore
wants to merge
11
commits into
main
Choose a base branch
from
feature-1322-scatter-highlight
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update: related backend PRs have been merged and are now deployed to QA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1322
This was a little funky because plotly already allows for highlighting - we just have to set the color appropriately in the trace! So this PR is more of a hijack of our current processing of scatterplot data to recolor the points.
A few considerations:
Scatterplot
but that means we have to traverse the entire dataset again. We already traverse the dataset inprocessInputData
, so we can add it there. Also we want to do it after the points get their normal color (given by overlay, etc), so that in the case where we want the highlighted points to be a different shape instead of color (for example), we still have the opportunity to keep the points' original colors.I ran into a bit of trouble with tooltips. Despite my best efforts, I couldn't hide the tooltips of the original data. I tried changing marker sizes, colors, lines, everything, but the tooltips still appeared. I finally found an option that I don't like because it removes some data, but at least the whole point isn't deleted from the trace.
Remaining To Dos: