-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting #321
Merged
Merged
Formatting #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the initial infrastructure for formatting a VHDL file.
What the formatter is capable of
What is still lacking for a feature complete formatter
In this PR, the
vhdl_lang
binary file has been extended to allow for the--format
flag. Whenvhdl_lang
is called likethe tool will print the formatted content of
my_file.vhd
into standard out. It will also check that the code is syntactically equivalent before and after.Formatting is tested using unit tests as well as integration test; checking that every VHDL file of the example project is formatted in a way that retains the syntax.
The initial skeleton is basically done. I want to do some more tests and smaller refactoring (e.g., to remove duplicated code and make some things more flexible), but other than that, the formatter is ready to be used.