Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #359
Add a linter for sensitivity lists.
For the most part, the linter is designed to be conservative concerning error codes and only emit warnings when absolutely certain. This means that a couple of potential problems will not be raised.
New error codes
missing_in_sensitivity_list
(default: warning): warns when there is a signal missing in the sensitivity list of a process that is read in a combinational process.superfluous_in_sensitivity_list
(default: warning): warns when there is a signal in the sensitivity list of a process that is not read inside the processCaveats
The linting only applies to combinational processes. To differentiate whether a process is combinational or sequential, a heuristic is applied.
Every process that contains any numbers of
if
statements with conditions that describe clocked elements are considered sequential. Clocked elements are eitherrising_edge(clk)
orclk'event
. This means that especially mixed processes likewon't be linted.