property call implementation

VKCOM · Feb 25, 2025 · 01cac99 · 01cac99
1 parent 17b226f
commit 01cac99
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 18 deletions.
diff --git a/src/linter/block_linter.go b/src/linter/block_linter.go
@@ -251,13 +251,6 @@ func (b *blockLinter) checkClass(class *ir.ClassStmt) {
 		case *ir.ClassMethodStmt:
 			members = append(members, classMethod)
 			b.walker.CheckParamNullability(value.Params)
-		case *ir.PropertyListStmt:
-			for _, element := range value.Doc.Parsed {
-				if element.Name() == "deprecated" {
-					b.report(stmt, LevelNotice, "deprecated", "Has deprecated field in class %s", class.ClassName.Value)
-				}
-			}
-			members = append(members, classOtherMember)
 		default:
 			members = append(members, classOtherMember)
 		}
@@ -566,7 +559,7 @@ func (b *blockLinter) checkNew(e *ir.NewExpr) {
 
 		if class.IsDeprecated() {
 			if class.WithDeprecationNote() {
-				b.report(e, LevelNotice, "deprecated", "Try to create instance of the class %s (%s)", class.Name, class.DeprecationInfo)
+				b.report(e, LevelNotice, "deprecated", "Try to create instance of the class %s that was marked as deprecated (%s)", class.Name, class.DeprecationInfo)
 			} else {
 				b.report(e, LevelNotice, "deprecatedUntagged", "Try to create instance %s class that was marked as deprecated", class.Name)
 			}
@@ -1414,6 +1407,14 @@ func (b *blockLinter) checkPropertyFetch(e *ir.PropertyFetchExpr) {
 	if fetch.isFound && !fetch.isMagic && !canAccess(b.classParseState(), fetch.className, fetch.info.AccessLevel) {
 		b.report(e.Property, LevelError, "accessLevel", "Cannot access %s property %s->%s", fetch.info.AccessLevel, fetch.className, fetch.propertyNode.Value)
 	}
+
+	if fetch.info.IsDeprecated() {
+		if fetch.info.WithDeprecationNote() {
+			b.report(e, LevelNotice, "deprecated", "Try to call property %s that was marked as deprecated (%s) in the class %s", fetch.propertyNode.Value, fetch.info.DeprecationInfo, fetch.className)
+		} else {
+			b.report(e, LevelNotice, "deprecatedUntagged", "Try to call property %s that was marked as deprecated in the class %s", fetch.propertyNode.Value, fetch.className)
+		}
+	}
 }
 
 func (b *blockLinter) checkStaticPropertyFetch(e *ir.StaticPropertyFetchExpr) {

diff --git a/src/linter/report.go b/src/linter/report.go
@@ -568,7 +568,7 @@ g();`,
 
 		{
 			Name:     "deprecatedUntagged",
-			Default:  false,
+			Default:  true,
 			Quickfix: false,
 			Comment:  "Report usages of deprecated symbols if the `@deprecated` tag has no description (see `deprecated` check).",
 			Before: `/**

diff --git a/src/linter/root.go b/src/linter/root.go
@@ -898,19 +898,26 @@ func (d *rootWalker) handleClassDoc(doc classPHPDocParseResult, cl *meta.ClassIn
 	}
 }
 
-func (d *rootWalker) parsePHPDocVar(doc phpdoc.Comment) (typesMap types.Map) {
-	for _, part := range doc.Parsed {
-		part, ok := part.(*phpdoc.TypeVarCommentPart)
+func (d *rootWalker) parsePHPDocVar(doc phpdoc.Comment) (typesMap types.Map, deprecationInfo meta.DeprecationInfo) {
+	for _, partDoc := range doc.Parsed {
+		part, ok := partDoc.(*phpdoc.TypeVarCommentPart)
 		if ok && part.Name() == "var" {
 			converted := phpdoctypes.ToRealType(d.ctx.typeNormalizer.ClassFQNProvider(), d.config.KPHP, part.Type)
 			moveShapesToContext(&d.ctx, converted.Shapes)
 			d.handleClosuresFromDoc(converted.Closures)
 
 			typesMap = types.NewMapWithNormalization(d.ctx.typeNormalizer, converted.Types)
 		}
+
+		rawPart, rawOk := partDoc.(*phpdoc.RawCommentPart)
+
+		if rawOk && rawPart.Name() == "deprecated" {
+			deprecationInfo.Deprecated = true
+			deprecationInfo.Reason = rawPart.ParamsText
+		}
 	}
 
-	return typesMap
+	return typesMap, deprecationInfo
 }
 
 func (d *rootWalker) enterPropertyList(pl *ir.PropertyListStmt) bool {
@@ -932,9 +939,14 @@ func (d *rootWalker) enterPropertyList(pl *ir.PropertyListStmt) bool {
 		}
 	}
 
-	phpDocType := d.parsePHPDocVar(pl.Doc)
+	phpDocType, deprecationInfo := d.parsePHPDocVar(pl.Doc)
 	typeHintType, _ := d.parseTypeHintNode(pl.Type)
 
+	deprecation, ok := attributes.Deprecated(pl.AttrGroups, d.ctx.st)
+	if ok {
+		deprecationInfo.Append(deprecation)
+	}
+
 	for _, pNode := range pl.Properties {
 		prop := pNode.(*ir.PropertyStmt)
 
@@ -955,9 +967,10 @@ func (d *rootWalker) enterPropertyList(pl *ir.PropertyListStmt) bool {
 
 		// TODO: handle duplicate property
 		cl.Properties[nm] = meta.PropertyInfo{
-			Pos:         d.getElementPos(prop),
-			Typ:         propTypes.Immutable(),
-			AccessLevel: accessLevel,
+			Pos:             d.getElementPos(prop),
+			Typ:             propTypes.Immutable(),
+			AccessLevel:     accessLevel,
+			DeprecationInfo: deprecationInfo,
 		}
 	}
 

diff --git a/src/linter/root_checker.go b/src/linter/root_checker.go
@@ -110,7 +110,7 @@ func (r *rootChecker) CheckPropertyList(pl *ir.PropertyListStmt) bool {
 		r.walker.Report(pl, LevelNotice, "implicitModifiers", "Specify the access modifier for %s explicitly", target)
 	}
 
-	docblockType := r.walker.parsePHPDocVar(pl.Doc)
+	docblockType, _ := r.walker.parsePHPDocVar(pl.Doc)
 
 	r.CheckCommentMisspellings(pl, pl.Doc.Raw)
 	r.CheckPHPDocVar(pl, pl.Doc, docblockType)