linter: null safety for functions, methods and properties for classes #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hidanio
force-pushed
the
hidanio/class_null_safety
branch
2 times, most recently
from
7f516ba to
a4e513d
Compare
Hidanio
added
enhancement
Hidanio
force-pushed
the
hidanio/class_null_safety
branch
from
2972b37 to
88b0bb0
Compare
src/meta/metainfo.go
Outdated
| @@ -129,6 +129,7 @@ type FuncInfo struct { | |||
| Flags FuncFlags | |||
| ExitFlags int // if function has exit/die/throw, then ExitFlags will be <> 0 | |||
| Internal bool | |||
| IsVariadic bool | |||
There was a problem hiding this comment.
I would combine this with Flags. It already has information about IsDeprecated, IsPure.
Or create separate flags for the types.
| return isNullable | ||
| } | ||
|
|
||
| func IsTypeMixed(typ Map) bool { |
There was a problem hiding this comment.
why not just type.Contains("mixed")? in this case, you're looking at []mixed simply as mixed
There was a problem hiding this comment.
You are right. I missed this
| return fn.Params[paramIndex] | ||
| } | ||
|
|
||
| func formatSlashesFuncName(fn meta.FuncInfo) string { |
There was a problem hiding this comment.
why? You've broken the FQN
There was a problem hiding this comment.
Why? This is only used in the error message output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.