dynamic rules: @fliter capturing any pattern not only variable #1249
+177
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hidanio
changed the title
Hidanio
force-pushed
the
hidanio/filter_capturing_any_pattern
branch
from
37d0238 to
0e9a399
Compare
Danil42Russia
approved these changes
Mar 1, 2025
| @@ -558,3 +558,37 @@ func (p *parser) checkForVariableInPattern(name string, pattern ir.Node, verifie | |||
|
|
|||
| return found | |||
| } | |||
|
|
|||
| func (p *parser) filterByPattern(name string, pattern ir.Node, verifiedVars map[string]struct{}) bool { | |||
There was a problem hiding this comment.
Let's add the tests? It's a very fragile place
src/tests/rules/rules_test.go
Outdated
There was a problem hiding this comment.
What's missing is a test that checks that the filter is type-aware.
// var
callFunc($name);
// str
callFunc("name");
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.