Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat document type and storage path #298

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

CodingAlias
Copy link

New Feature: added support for DocumentType and StoragePath API functionality.

CodingAlias and others added 4 commits December 28, 2024 13:26
Introduced classes, interfaces, and clients for handling `DocumentType` and `StoragePath` entities, including creation, retrieval, and deletion methods. Updated routing and serialization to accommodate these new API endpoints.
Introduced classes, interfaces, and clients for handling `DocumentType` and `StoragePath` entities, including creation, retrieval, and deletion methods. Updated routing and serialization to accommodate these new API endpoints.
… into feat-DocumentTypeAndStoragePath

# Conflicts:
#	source/VMelnalksnis.PaperlessDotNet/StoragePaths/StoragePath.cs
#	source/VMelnalksnis.PaperlessDotNet/StoragePaths/StoragePathCreation.cs
Copy link
Owner

@VMelnalksnis VMelnalksnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add simple integration tests for document types and storage paths, where you create it, get it and delete it. Also check the ReSharper warnings added in the PR.

@@ -20,6 +22,8 @@ namespace VMelnalksnis.PaperlessDotNet.Serialization;
[JsonSerializable(typeof(CorrespondentCreation))]
[JsonSerializable(typeof(PaginatedList<Document>))]
[JsonSerializable(typeof(Document))]
[JsonSerializable(typeof(DocumentType))]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to also add DocumentTypeCreation and StoragePathCreation

@@ -33,4 +33,8 @@
<None Include="..\..\README.md" Pack="true" PackagePath="\"/>
</ItemGroup>

<ItemGroup>
<Compile Remove="DocumentTypes\MatchingAlgorithm.cs" />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably is not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants