-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VVPPをデフォルトエンジンに指定可能にし、未インストール時にインストールするか聞くようにする #2270
Open
Hiroshiba
wants to merge
52
commits into
VOICEVOX:main
Choose a base branch
from
Hiroshiba:指定されているVVPPがなかったら確認後にインストールし、使えるようにするようにする
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
The head ref may contain hidden characters: "\u6307\u5B9A\u3055\u308C\u3066\u3044\u308BVVPP\u304C\u306A\u304B\u3063\u305F\u3089\u78BA\u8A8D\u5F8C\u306B\u30A4\u30F3\u30B9\u30C8\u30FC\u30EB\u3057\u3001\u4F7F\u3048\u308B\u3088\u3046\u306B\u3059\u308B\u3088\u3046\u306B\u3059\u308B"
+217
−37
Open
Changes from all commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
f1bc063
stash
Hiroshiba 3310c6f
Merge remote-tracking branch 'upstream/main' into 指定されているVVPPがなかったら確認…
Hiroshiba 06ac776
stash
Hiroshiba 8237c8f
Merge remote-tracking branch 'upstream/main' into pr/Hiroshiba/2270
Hiroshiba 674d116
とりあえずデフォルトエンジンをダウンロードできるようにした
Hiroshiba f5f705d
typo
Hiroshiba e2e3b88
docsを移動
Hiroshiba 3b642aa
リファクタリング
Hiroshiba f6a51da
コントローラーに移す
Hiroshiba 87e666f
fetchInfosToInstall
Hiroshiba 2c6a974
typos
Hiroshiba 187cc8a
Merge remote-tracking branch 'upstream/main' into 指定されているVVPPがなかったら確認…
Hiroshiba 8884110
.envのデフォルトエンジン情報を読み出す部分を共通化する
Hiroshiba 6e637ad
.
Hiroshiba 1627f00
Merge branch 'loadEnvEngineInfosに切り出し' into 指定されているVVPPがなかったら確認後にインスト…
Hiroshiba 6d56d0b
m
Hiroshiba a198568
typing
Hiroshiba 51e6461
a
Hiroshiba c9d4edf
微調整
Hiroshiba e179306
Merge remote-tracking branch 'upstream/main' into 指定されているVVPPがなかったら確認…
Hiroshiba 692f001
戻す
Hiroshiba ad41881
名称変更とか
Hiroshiba 016e142
fetchAdditionalEngineInfosをfetchVvppEngineInfosとfetchRegisteredEngine…
Hiroshiba 965cee5
Merge remote-tracking branch 'upstream/main' into 指定されているVVPPがなかったら確認…
Hiroshiba d9cc465
fetchDefaultEngineInfosをメソッド化
Hiroshiba c6f1d71
loadEngineInfoを中に移動
Hiroshiba cb5d716
要らない引数わたしを除去
Hiroshiba 6e155bf
fetchAdditionalEngineInfosをなくす
Hiroshiba b74cce6
要らない処理を省いた
Hiroshiba 166ea3d
refactor: エンジン情報管理のロジックを改善し、エンジン情報の取得メソッドを整理
Hiroshiba 13e9a14
まだ要らなかった
Hiroshiba 7c8c4f8
戻したり移動したり
Hiroshiba f7b17d6
移動はしない方が良さそう
Hiroshiba 32a2f2e
FIXME要らなくなってた
Hiroshiba bacf688
ちょっとわかりやすく
Hiroshiba c0219f2
エンジン情報の取得に関するコメントを修正
Hiroshiba d8013ae
エンジン情報の取得に関するコメントを修正
Hiroshiba e903075
Merge branch 'main' into EngineInfoManagerのリファクタリング
Hiroshiba b2434d6
Merge remote-tracking branch 'upstream/main' into 指定されているVVPPがなかったら確認…
Hiroshiba 02e758a
Merge remote-tracking branch 'origin/EngineInfoManagerのリファクタリング' into…
Hiroshiba 687212c
逆だった
Hiroshiba 40e180a
Merge branch 'main' into 指定されているVVPPがなかったら確認後にインストールし、使えるようにするようにする
Hiroshiba 973a5a5
Merge remote-tracking branch 'upstream/main' into 指定されているVVPPがなかったら確認…
Hiroshiba cee971a
refactor: エンジンとパッケージ情報の取得メソッドを改善し、型定義を更新
Hiroshiba c054061
refactor: ダウンロード処理のエラーハンドリングを改善し、失敗時のファイル削除を追加
Hiroshiba b5756d2
refactor: getSuitableVariantをgetSuitablePackageInfoに名称変更し、関連する変数名を更新
Hiroshiba 091df5f
docs: エンジン周りに関するドキュメントを削除
Hiroshiba fa29982
refactor: デフォルトエンジンのタイプチェックを追加し、パス以外の場合にエラーをスロー
Hiroshiba 32f334c
Merge branch 'main' into 指定されているVVPPがなかったら確認後にインストールし、使えるようにするようにする
Hiroshiba 9fa130e
コメント追記
Hiroshiba 39b86d8
Merge branch 'main' into 指定されているVVPPがなかったら確認後にインストールし、使えるようにするようにする
Hiroshiba 78c8b88
Add TODO comment for memory optimization
Hiroshiba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
globalのfetchを使っていますがelectronのfetch(net.fetch)を使うべきだと思います。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
みた感じそこまで変わらなさそう?( https://www.electronjs.org/ja/docs/latest/tutorial/progress-bar が適用されるというわけでもなさそうだし)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sabonerune
ちなみにelectronのfetchを使うべき理由って何でしょうか 👀
聞いてる理由は単純に、知識がなくて違いがわからないためです!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hiroshiba
Chromiumの機能を使うためシステムのプロキシ検出などがあるようですがあまりかわらないかもしれません。
https://www.electronjs.org/ja/docs/latest/api/net