Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for 3d views. Updates combined 2d/3d view. #492

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

whunter
Copy link
Member

@whunter whunter commented Nov 4, 2024

Adds support for 3d views. Updates combined 2d/3d view.


Description/changes? (:star:)

  • Decouples the 3d view from the combined view to support records that have a 3d model but no 2d tiles.
  • Three use cases for Entomology collection should now work: 2d only / 3d only / both
  • Brings 2d view (for all records) into the same layout as 3d and combined views

How should this be tested?

Check that three use cases for the entomology project work correctly:

Additional Notes:

  • branch: 3d_only
  • BIG BIG thanks to @sushmadeegojuVT for their awesome work on these changes

Interested parties

@otokama
@goynejennifer

working?

clean up

amplify pull

amplify pull components

runtime

collectionmap style

post-push

more amplify
@whunter whunter requested review from asthad1 and removed request for otokama and goynejennifer December 2, 2024 18:00
Copy link
Collaborator

@asthad1 asthad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all three use cases as mentioned in the PR. All three works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants