-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to cryptography. #288
base: master
Are you sure you want to change the base?
Conversation
Potentially, both could be supported with |
I'm curious what kind of errors you are getting installing cryptography? I know the maintainers of it, and I know they spend a bunch of effort to ensure that there are wheels for all major platforms, so that installation shouldn't be an issue. I think the only semi-common platform they don't provide wheels for is alpine linux (and I suspect that is largely because there isn't a good standard of how to build compatible wheels; see pypa/manylinux#37 for example). |
It was long time ago, and I can't recall specifics. But it made installs slow and error prone due compilation step or having to install various libraries. Cygwin was painful, and I recall issues with linux and windows installs. The switch to I've thought before about simply having both, and preferring |
That should no longer be necessary; cryptography added manylinux wheels in v2.0 (2017), which will be used by any recent version of pip (>8.1; 2016). (Although there aren't cygwin wheels). |
Allows for the raw buffer to be returned in the response
This garantees that the output is serializable by JSON (no bytes objects)
Fix for a bug reported in ValvePython#13
08fd8f3
to
c16b85c
Compare
No description provided.