-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docker Image to Ubuntu 24.04 ( Noble ) #2739
base: develop
Are you sure you want to change the base?
Changes from 24 commits
5b3aa20
dd9691e
312aed8
d28080c
3b367ce
aee9a69
f3ef893
e0dad5d
12be863
cfd11ad
3a9de05
4c38733
bbcf60d
30b8230
c798cef
87ba465
fb41956
80275ed
8d9dd89
237b447
3dc8769
c705505
e85f98a
c72778f
33db168
227a983
2367444
6809d61
2d42d49
754ac15
c544d5a
196887e
d224835
060f8a0
3e6aec5
ebf8675
a6b4f7f
0094cb0
88418dd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# git lfs (large file storage plugin for git) | ||
deb https://packagecloud.io/github/git-lfs/ubuntu/ noble main | ||
deb-src https://packagecloud.io/github/git-lfs/ubuntu/ noble main |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
# MariaDB 10.11 repository list - created 2024-08-27 19:47 UTC | ||
# MariaDB 10.11 repository list - created 2024-10-19 19:33 UTC | ||
# https://mariadb.org/download/ | ||
# deb.mariadb.org is a dynamic mirror if your preferred mirror goes offline. See https://mariadb.org/mirrorbits/ for details. | ||
# deb [signed-by=/etc/apt/keyrings/mariadb-keyring.pgp] https://deb.mariadb.org/10.11/ubuntu focal main | ||
deb [signed-by=/etc/apt/keyrings/mariadb-keyring.pgp] https://mariadb.gb.ssimn.org/repo/10.11/ubuntu focal main | ||
# deb-src [signed-by=/etc/apt/keyrings/mariadb-keyring.pgp] https://mariadb.gb.ssimn.org/repo/10.11/ubuntu focal main | ||
deb [signed-by=/etc/apt/keyrings/mariadb-keyring.pgp] http://mariadb.mirrors.ovh.net/MariaDB/repo/10.11/ubuntu focal main | ||
# deb-src [signed-by=/etc/apt/keyrings/mariadb-keyring.pgp] http://mariadb.mirrors.ovh.net/MariaDB/repo/10.11/ubuntu focal main |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# Provides Nginx mainline | ||
deb https://nginx.org/packages/mainline/ubuntu/ noble nginx | ||
deb-src https://nginx.org/packages/mainline/ubuntu/ noble nginx |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# Provides Node.js | ||
deb http://deb.nodesource.com/node_14.x noble main | ||
deb-src http://deb.nodesource.com/node_14.x noble main |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# Provides PHP | ||
deb https://ppa.launchpadcontent.net/ondrej/php/ubuntu noble main | ||
deb-src https://ppa.launchpadcontent.net/ondrej/php/ubuntu noble main |
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -96,8 +96,21 @@ function shyaml_setup() { | |||||||
# Used for passing custom parameters to the bash provisioning scripts | ||||||||
if [ ! -f /usr/local/bin/shyaml ]; then | ||||||||
vvv_info " * Installing Shyaml for bash provisioning.." | ||||||||
sudo pip3 install wheel | ||||||||
sudo pip3 install shyaml | ||||||||
|
||||||||
local OSVERSION_NUMBER=$(lsb_release lsb_release -sr) | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. shellcheck will probably flag this and a few other things, it should be something like this:
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. adjusted There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. huh, this adjustments causing error for some reason
https://github.com/Varying-Vagrant-Vagrants/VVV/actions/runs/11580749924/job/32239965581?pr=2739 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. reverted it to the original changes. the checks / linting seems to be fine: https://github.com/Varying-Vagrant-Vagrants/VVV/actions/runs/11581054132/job/32240928199?pr=2739 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ah I think the problem is a mistake on my part, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. adjusted, and seems to be ran okay: https://github.com/Varying-Vagrant-Vagrants/VVV/actions/runs/11858839047/job/33050382482?pr=2739 |
||||||||
|
||||||||
# Ubuntu 24 making it hard to install pip packages, throwing externally-managed-environment error | ||||||||
# https://stackoverflow.com/a/75722775 | ||||||||
if dpkg --compare-versions "${OSVERSION_NUMBER[@]}" ge "24.04" | ||||||||
then | ||||||||
# to make it available globally this is the last workaround, hopefully it doesn't break the system | ||||||||
# TODO: try to find a better alternative way to install | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is there somewhere I can read up on why this happens or where the fix came from? Would be good to have it in the comments, I've created a separate PR for shyaml fixes There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||||
sudo pip3 install wheel --break-system-packages | ||||||||
sudo pip3 install shyaml --break-system-packages | ||||||||
else | ||||||||
sudo pip3 install wheel | ||||||||
sudo pip3 install shyaml | ||||||||
fi | ||||||||
fi | ||||||||
} | ||||||||
export -f shyaml_setup | ||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# VVV mirror packages | ||
# deb https://ppa.launchpadcontent.net/varying-vagrant-vagrants/php/ubuntu noble main | ||
# deb-src https://ppa.launchpadcontent.net/varying-vagrant-vagrants/php/ubuntu noble main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this trigger a VM rebuild for exsting Ubuntu 22 instances that upgrade?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question, i dont know. it would be vagrant territory, no ? the decision whether docker container need rebuild or not would be based on what vagrant flow will be issued. in any case better to test it, i'll try to test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
main concerns is if vagrant would kick up a fuss about mismatching images or if it would discard the container ( and the database + data ) to create a new 24 container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so i tested this, this is how i tested it
use
upstream/develop
branchvagrant up --provision
vagarant ssh
vagrant@vvv:~$ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.6 LTS Release: 20.04 Codename: focal
switch to
origin/docker-provider
vagrant halt
to stop dockervagrant reload --provision
to trigger reprovisionvagarant ssh
, expecting the Ubuntu should stay in 20.04Last login: Fri Nov 15 15:33:51 2024 from 172.17.0.1 vagrant@vvv:~$ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.6 LTS Release: 20.04 Codename: focal
i think this is what we expected, right ?
i think what we can do is, add somewhere in docs ( if we haven't), if user wants to upgrade their OS is by doing
db_backup
vagrant destroy
vagrant up --provision
--> this step will trigger 24.04db_restore