[MIG] stock_by_warehouse_sale: Migration to 17.0 T#79454 #1643
Conversation
|
@isaako34 and @rolandojduartem please review. |
|
@xmglord task in the MR description please |
stock_by_warehouse_sale/i18n/es.po
Outdated
| # | ||
| msgid "" | ||
| msgstr "" | ||
| "Project-Id-Version: Odoo Server 16.0+e\n" |
There was a problem hiding this comment.
Update the whole .po, please
|
Please, test your PR functionally. This error happened when I tried to open a sale order line
|
Actually, this error comes from stock_by_warehouse, it is required functional review previous merging cc @luisg123v @desdelinux |
|
Use this as example https://github.com/odoo/odoo/blob/ce3b096de7a0dcbf2bc8387d0c17ac3d320a7ec4/addons/mail/static/src/js/onchange_on_keydown.js#L69, the fix in other PR and be sure to test in the both modules. |
xmglord
changed the title
xmglord
force-pushed
the
17.0-mig_v17_stock_warehouse_sale-xmglord
branch
5 times, most recently
from
3c2616f to
d87b040
Compare
|
@luisg123v please review but don't merge until @rolandojduartem give his functional review. |
|
No, the changes on stock_by_warehouse must be other PR, that is a fix, not a migration, you can rebase over that PR for functional review, but I do not think is a good idea mix changes in the same PR |
stock_by_warehouse/static/src/components/warehouse/warehouse_field.js
Outdated
Show resolved
Hide resolved
stock_by_warehouse/static/src/components/warehouse/warehouse_field.js
Outdated
Show resolved
Hide resolved
xmglord
force-pushed
the
17.0-mig_v17_stock_warehouse_sale-xmglord
branch
2 times, most recently
from
931ba79 to
a0281b6
Compare
xmglord
force-pushed
the
17.0-mig_v17_stock_warehouse_sale-xmglord
branch
from
a0281b6 to
0c43bdc
Compare
|
This MR is not rebased over !1651, so it fails |
|
|
||
| def _compute_get_warehouses_stock(self): | ||
| for line in self: | ||
| line.warehouses_stock = line.product_id.with_context( |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
It doesn't work since the field in the product is not yet calculated and is not stored so is need to call the compute directly.
xmglord
force-pushed
the
17.0-mig_v17_stock_warehouse_sale-xmglord
branch
from
0c43bdc to
248ec07
Compare
I already rebase but for some reason when installing this modules the widget fails. |
|
Hello, what are we missing here? @luisg123v @xmglord |
|
I am going to test it then |
|
I think it is not working as I expected, see the sale order, I did not activate the button and the widget was loaded at the beggining, could you check it?
|
| def _compute_warehouse_stock(self): | ||
| for record in self: | ||
| record.warehouse_id = self.order_id.warehouse_id | ||
| record._compute_get_warehouses_stock() |
There was a problem hiding this comment.
Yes, you forgot the condition of warehouses_stock_recompute
|
|
||
| def _compute_get_warehouses_stock(self): | ||
| for line in self: | ||
| line.warehouses_stock = line.product_id.with_context( |
|
Alsoo llok the button, the widget and the button are so close |
…ad (Vauxoo#1358) We need avoid using compute fields as possible because of the following issue: - odoo/odoo#30578 warehouses_stock is a computed field used just one time but re-computed too many times: - Opening sale order (one time by each line) - Saving sale order - Choosing a product_id And it computation is more and more slow when the database grows. It is making a big overhead saving sale.order. With this change we have the same behaviour using it just for onchange product_id or forcing from a seudo-button (field boolean) A real button is not used since that it requires save the record to work Using the technical of fields with store=False and onchange methods Check more details from Vauxoo#1358
In order to get the real value, since that this field is not set when onchange method is used
The following is performed: - Remove useless test that actually did nothing - Remove data tags from views - Remove encoding headers from Python files - Remove superfluous readonly attribute from related fields - Remove useless keys from the manifest - Fix typos on the README
* [I18N] stock_by_warehouse_sale: Fix term names Some term names are handled differently on v12.0, but those changes were not taken into account when migrating this module from v11.0. * [I18N] stock_by_warehouse_purchase: Fix term names Some term names are handled differently on v12.0, but those changes were not taken into account when migrating this module from v11.0.
This removes: - Hencoding headers, fixing lint `utf8-coding-comment` - Headers like `# Part of Odoo` - And other ones
In previous Odoo versions, the form view was poped up when editing a sale order line, as long as the option "Manage Product packaging" was enabled. This is no longer the case [1], so we re-enable it manually, in order to be able to see current inventory when filling a line. [1] odoo/odoo@e813487e75f1
…able products This functionality is for storable products to show the information in the warehouses, now this field is invisible for products which are not storable products.
xmglord
force-pushed
the
17.0-mig_v17_stock_warehouse_sale-xmglord
branch
2 times, most recently
from
dcf2f79 to
60c0afc
Compare
|
@rolandojduartem I already fix the space between the widget and the button, please review again. |
|
Friendly Reminder @rolandojduartem |
|
Functionally and technically LGTM @luisg123v |
- Simplify the way to define modifiers as states, required, readonly, invisible and column_invisible as part of [1]. - Adapt the stock by warehouse field to be computed. [1] odoo/odoo#104741
xmglord
force-pushed
the
17.0-mig_v17_stock_warehouse_sale-xmglord
branch
from
60c0afc to
80a9672
Compare
No description provided.