[REM] sale_margin_percentage: remove margin_percentage field in favor of native one I#25764 #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmglord
changed the title
xmglord
force-pushed
the
15.0-remove_percetage_field-xmglord
branch
4 times, most recently
from
c58e8ea to
55cb2f8
Compare
|
@isaako34 and @rolandojduartem please review. |
rolandojduartem
suggested changes
Apr 12, 2024
xmglord
force-pushed
the
15.0-remove_percetage_field-xmglord
branch
2 times, most recently
from
5734928 to
09fc66a
Compare
xmglord
force-pushed
the
15.0-remove_percetage_field-xmglord
branch
from
09fc66a to
043dc7f
Compare
| class SaleOrder(models.Model): | ||
| _inherit = "sale.order" | ||
|
|
||
| margin_percentage = fields.Float( |
There was a problem hiding this comment.
I think we need a migration script here, it is a stored field.
|
There errors in the CI, is that expected? |
xmglord
force-pushed
the
15.0-remove_percetage_field-xmglord
branch
from
043dc7f to
544e25b
Compare
|
@luisg123v please review. |
luisg123v
requested changes
Apr 24, 2024
| from odoo import api, fields, models | ||
|
|
||
|
|
||
| class SaleOrderLine(models.Model): |
There was a problem hiding this comment.
Could you split by model on a separate commit, please?
There was a problem hiding this comment.
Commit message: it's -> its
xmglord
force-pushed
the
15.0-remove_percetage_field-xmglord
branch
from
544e25b to
d52aa02
Compare
To follow our good practices each model should be in its own file with the same name as the model.
… of native one The field margin_percentage is no longer needed since native module sale_margin have the field margin_percent that serve the same propose. Also the field margin_threshold must be updated since it was used as a percentage but the native field margin_percent is a ration so we must follow the same pattern.
xmglord
force-pushed
the
15.0-remove_percetage_field-xmglord
branch
from
d52aa02 to
550a57c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field margin_percentage is no longer needed since native module
sale_margin have the field margin_percent that serve the same propose.
Also the field margin_threshold must be updated since it was used as a
percentage but the native field margin_percent is a ration so we must
follow the same pattern.