Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if SIGNATURE_FILE_NAME exists and use it as output_filename #29

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Check if SIGNATURE_FILE_NAME exists and use it as output_filename #29

merged 1 commit into from
Sep 9, 2024

Conversation

Luca1991
Copy link
Contributor

@Luca1991 Luca1991 commented Sep 9, 2024

Hi,
I've already discussed this PR with @psifertex on Slack.
Long story short: I'm working on a script to automatically create signatures from .LIB files (more info here: #28) and this PR basically allows me to set the filename for the resulting .SIG directly from my script.

Thanks,
Luca

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@psifertex psifertex merged commit 7ffd32e into Vector35:master Sep 9, 2024
1 check was pending
@psifertex
Copy link
Member

lgtm

@Luca1991 Luca1991 deleted the signature_file_name branch September 9, 2024 20:23
@Luca1991
Copy link
Contributor Author

Luca1991 commented Sep 9, 2024

@psifertex do you know when it will be possible to download the new version containing this PR from the official plugin repository? Thanks a lot.

@psifertex
Copy link
Member

It should be live now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants