Skip to content

Commit

Permalink
Update yml files to use consistent new line convention
Browse files Browse the repository at this point in the history
  • Loading branch information
davidbooke4 committed Oct 24, 2024
1 parent 616da99 commit 653e1ae
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 12 deletions.
2 changes: 1 addition & 1 deletion models/staging/stg_ga4__event_to_query_string_params.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ unit_tests:
aaa,param1,value1
aaa,param2,value2
bbb,param1,
ccc,param1,
ccc,param1,
7 changes: 0 additions & 7 deletions models/staging/stg_ga4__events.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ models:
the data shows that this is not always the case. When a user_engagement event does not fire, the engagement_time_msec parameter is assigned to the next page_view.
This engagement time should be credited to the previous page,
so for page_view events this field uses the session_key and page_referrer as the key while all other events use the session_key and page_location.
unit_tests:
- name: query_parameter_removal
description: "Check that query parameters get removed from the model."
Expand All @@ -42,7 +41,6 @@ unit_tests:
- {page_location: https://asite.com/anotherpage, page_referrer: https://asite.com/previous_page?utm_source=source_value}
- {page_location: https://anothersite.com/page?not_excluded_param=val&param=also_not_excluded, page_referrer: https://anothersite.com/previous_page#utm_source=source_value#hash=hash_value}
- {page_location: https://twoparams.com/page, page_referrer: https://twoparams.com/previous_page#hash=hash_value}

- name: query_parameter_remove_all
description: "Check that the '*all*' flag removes all query parameters from the model."
model: stg_ga4__events
Expand All @@ -58,7 +56,6 @@ unit_tests:
rows:
- {page_location: https://asite.com/page, page_referrer: https://asite.com/previous_page}
- {page_location: https://asite.com/anotherpage, page_referrer: https://asite.com/previous_page}

- name: query_parameter_extraction
description: "Check that query parameters get extracted from the model and added as new fields."
model: stg_ga4__events
Expand All @@ -82,7 +79,6 @@ unit_tests:
- {query_param_param1: val, query_param_param2: null, query_param_param3: null}
- {query_param_param1: another_val, query_param_param2: second_val, query_param_param3: value3}
- {query_param_param1: null, query_param_param2: null, query_param_param3: null}

- name: hostname_extraction_from_url
description: "Check that the hostname is extracted from the URL"
model: stg_ga4__events
Expand All @@ -101,7 +97,6 @@ unit_tests:
- {page_hostname: cool-site.com}
- {page_hostname: example.site.app}
- {page_hostname: madeup.org}

- name: query_string_extraction_from_url
description: "Check that the query string is extracted from the URL"
model: stg_ga4__events
Expand All @@ -116,7 +111,6 @@ unit_tests:
- {page_query_string: query_string=something}
- {page_query_string: null}
- {page_query_string: utm_term=test-term&utm_source=test-source}

- name: page_path_extraction
description: "Check that the page path is extracted from the URL"
model: stg_ga4__events
Expand All @@ -133,7 +127,6 @@ unit_tests:
- {page_path: /with/this-path}
- {page_path: /}
- {page_path: /page}

- name: test_base_to_stg_ga4__events
description: "Check whether a given row from base_ga4__events produces the expected row in stg_ga4__events"
model: stg_ga4__events
Expand Down
2 changes: 1 addition & 1 deletion models/staging/stg_ga4__page_conversions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,4 @@ unit_tests:
A,2
B,1
overrides:
vars: {conversion_events: ['page-view']}
vars: {conversion_events: ['page-view']}
2 changes: 1 addition & 1 deletion models/staging/stg_ga4__session_conversions_daily.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,4 @@ unit_tests:
overrides:
macros:
is_incremental: false
vars: {conversion_events: ['my-conversion']}
vars: {conversion_events: ['my-conversion']}
1 change: 0 additions & 1 deletion models/staging/stg_ga4__sessions_traffic_sources.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ models:
description: First non-null source value of the session
tests:
- not_null

unit_tests:
- name: test_default_channel_grouping
description: Test whether the defaul_channel_grouping macro is assigning channels correctly
Expand Down
1 change: 0 additions & 1 deletion models/staging/stg_ga4__user_id_mapping.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ models:
tests:
- not_null
- unique

unit_tests:
- name: test_user_id_mapping
description: Test whether the latest client_key to user_id mapping logic is correct
Expand Down

0 comments on commit 653e1ae

Please sign in to comment.