Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin): FakeProfileThemesAndEffects #1930

Open
wants to merge 126 commits into
base: main
Choose a base branch
from

Conversation

ryan-0324
Copy link
Contributor

@ryan-0324 ryan-0324 commented Oct 30, 2023

This plugin is meant to replace FakeProfileThemes.
It allows profile theming and the usage of profile effects by hiding the colors and effect ID in your About Me using invisible, zero-width characters.

  • It includes a UI (called the FPTE Builder) for generating the profile theme/effect (FPTE) strings in the User Profile and Server Profiles settings pages.
  • The FPTE strings can be made backwards compatible so that users of older plugins will still see your profile theme.
  • When the "Build backwards compatible FPTE" setting is off, the generated strings will use at most 22 characters (12 codepoints) of your About Me.
  • The FPTE Builder can be hidden through the plugin settings.

src/plugins/fakeProfileThemesAndEffects/index.tsx Outdated Show resolved Hide resolved
src/plugins/fakeProfileThemesAndEffects/index.tsx Outdated Show resolved Hide resolved
src/plugins/fakeProfileThemesAndEffects/index.tsx Outdated Show resolved Hide resolved
src/plugins/fakeProfileThemesAndEffects/index.tsx Outdated Show resolved Hide resolved
src/plugins/fakeProfileThemesAndEffects/index.tsx Outdated Show resolved Hide resolved
src/plugins/fakeProfileThemesAndEffects/index.tsx Outdated Show resolved Hide resolved
src/plugins/fakeProfileThemesAndEffects/index.tsx Outdated Show resolved Hide resolved
src/plugins/fakeProfileThemesAndEffects/index.tsx Outdated Show resolved Hide resolved
src/plugins/fakeProfileThemesAndEffects/index.tsx Outdated Show resolved Hide resolved
@Covkie
Copy link
Contributor

Covkie commented Aug 31, 2024

Some issues:

  1. The stock profile effect editor is patched by this plugin resulting in it displaying all effects as unlocked and are unable to apply any & it falsely showing the remove effect button. Should behave like Decor where it doesn't modify the stock feature.

  2. The FPTE Builder should auto fill with the values from the bio.

  3. The FPTE Builder should have buttons to save to bio without manual copy & pasting being required And likewise have a clear button.

@ryan-0324
Copy link
Contributor Author

Some issues:

  1. The stock profile effect editor is patched by this plugin resulting in it displaying all effects as unlocked and are unable to apply any & it falsely showing the remove effect button. Should behave like Decor where it doesn't modify the stock feature.
  2. The FPTE Builder should auto fill with the values from the bio.
  3. The FPTE Builder should have buttons to save to bio without manual copy & pasting being required And likewise have a clear button.
  1. This seems to be a recent breakage. Thanks for letting me know.
  2. I've though about adding something like this before, and it seems reasonable.
  3. This has been suggested before, and I don't think it's worth the added complexity:
    1. Should I just prepend the FPTE string to the user's bio, displaying an error if their bio doesn't have enough space or already starts with an FPTE character?
    2. Or should I try to automatically detect preexisting FPTE strings and strings from other plugins, and remove them from the user's bio, showing an error if there still isn't enough space?
    3. If not (ii), when the user's bio already starts with an FPTE character, should I add a non-FPTE character as a separator, or should I display an error?
    4. Should I send an API request to save the user's bio, or should I have the user do it manually?

@Covkie
Copy link
Contributor

Covkie commented Sep 13, 2024

The stock profile effect setting still falsely shows the "Remove Effect" button

Or should I try to automatically detect preexisting FPTE strings and strings from other plugins, and remove them from the user's bio, showing an error if there still isn't enough space?

Bio processing is already in place, can you not just replace the detected/processed fpte string

Should I send an API request to save the user's bio, or should I have the user do it manually?

The user should do it manually imo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.