-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Plugin): CopyFileContents #2790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im tired and youre asking for a review, so i gave it to ya lol
just verify everything is accurate before changing stuff.
You never change setRecentlyCopied back to false, is that intended? |
Yes. That's how it works in code blocks, so I recreated it here. |
I still feel like it should |
I added a toast when copying. It's currently stay as a checkmark with a toast (the first video). Videoscfc_stay_toast.mp4cfc_change_back_toast.mp4 |
I fixed the buggy behavior and made the checkmark change back, it makes way more sense |
Thank you for the new plugin! |
Adds a button to copy the contents of a text file (even if the text isn't in the tiny preview).
After clicking, the copy icon will turn into a checkmark (like in large codeblocks), and the text will be copied to your clipboard.
For files over 50kb (50 thousand characters) that don't fully show in the "View whole file" preview, it shows "File too large to copy". I made a version that fetches files that are large, but I don't think that's necessary for 99% of users, and it could lead to problems if a user tries to copy a huge file.
This pr also updates the copy icon in
components\icons.tsx
(because the icon is used in this plugin), as the icon that was in there is long outdated.Images
A file containing 51kb that is unable to be copied (the first 683 numbers in the fibonacci sequence in this example).