-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LastFMRichPresence: add listenbrainz support #2908
base: main
Are you sure you want to change the base?
Conversation
6e6fe9f
to
13481ab
Compare
@Nuckyz could this be looked at? I'd appreciate this plugin a lot, thanks! |
I've got some code here that can use lb's websocket to listen for listens instead of polling if that's of any interest |
@yellowsink would be cool if this was integrated with my current thing, maybe as a toggle, i would accept a PR into this branch if you're up to integrating this here! |
respectfully, I don't intend to contribute to this, I just wanted to let you know that listenbrainz has a websocket, and I've got some tested open source code to use it that you're welcome to if you want :) |
adds support for listenbrainz to the LastFMRichPresence plugin
fulfills Vencord/plugin-requests#634
might want to reconsider the name of the plugin now, if that's feasible
or, alternatively, move listenbrainz support to a completely separate plugin, but currently theyd be basically copy-pasted as theres very little difference from the last.fm plugin unless additional listenbrainz-specific features are added, like the one described below
also, if the listenbrainz functionality will be kept in this plugin, would be nice if the creator of the application could add listenbrainz assets to the like the last.fm ones (and, perhaps, some for popular music players/services as well)