Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LastFMRichPresence: add listenbrainz support #2908

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

cgytrus
Copy link

@cgytrus cgytrus commented Sep 25, 2024

adds support for listenbrainz to the LastFMRichPresence plugin
fulfills Vencord/plugin-requests#634

might want to reconsider the name of the plugin now, if that's feasible
or, alternatively, move listenbrainz support to a completely separate plugin, but currently theyd be basically copy-pasted as theres very little difference from the last.fm plugin unless additional listenbrainz-specific features are added, like the one described below

also, if the listenbrainz functionality will be kept in this plugin, would be nice if the creator of the application could add listenbrainz assets to the like the last.fm ones (and, perhaps, some for popular music players/services as well)

@TimovVeen
Copy link

@Nuckyz could this be looked at? I'd appreciate this plugin a lot, thanks!

@yellowsink
Copy link

I've got some code here that can use lb's websocket to listen for listens instead of polling if that's of any interest
https://github.com/yellowsink/shelter-plugins/blob/master/plugins/lastfm/listenbrainz.ts

@cgytrus
Copy link
Author

cgytrus commented Jan 5, 2025

@yellowsink would be cool if this was integrated with my current thing, maybe as a toggle, i would accept a PR into this branch if you're up to integrating this here!

@yellowsink
Copy link

respectfully, I don't intend to contribute to this, I just wanted to let you know that listenbrainz has a websocket, and I've got some tested open source code to use it that you're welcome to if you want :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants