Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme Update #376

Merged
merged 6 commits into from
Jan 19, 2024
Merged

Readme Update #376

merged 6 commits into from
Jan 19, 2024

Conversation

vhavlena
Copy link
Collaborator

@vhavlena vhavlena commented Jan 12, 2024 •
edited
Loading

Fixing README.md to be more up-to-date.

@codecov Codecov
Copy link

codecov bot commented Jan 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (efadb56) 72.05% compared to head (864a697) 72.05%.
Report is 1 commits behind head on devel.

Additional details and impacted files 
@@           Coverage Diff           @@
##            devel     #376   +/-   ##
=======================================
  Coverage   72.05%   72.05%           
=======================================
  Files          30       30           
  Lines        3686     3686           
  Branches      839      839           
=======================================
  Hits         2656     2656           
  Misses        735      735           
  Partials      295      295

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vhavlena vhavlena marked this pull request as ready for review January 12, 2024 12:18
Adda0
Adda0 reviewed Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@Adda0 Adda0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you plan to resolve the remaining tasks in #319 in this PR?

jurajsic
jurajsic approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@jurajsic jurajsic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@vhavlena
Copy link
Collaborator Author

LGTM. Do you plan to resolve the remaining tasks in #319 in this PR?

I was not aware of this Issue. Maybe I include something that makes sense to me.

@Adda0
Copy link
Collaborator

Adda0 commented Jan 16, 2024 •
edited
Loading

Sounds good to me. Let me know when you have finished working on this PR, and the PR is ready for final review.

@vhavlena
Copy link
Collaborator Author

Ok, it is ready now. Please look at it.

Adda0
Adda0 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@Adda0 Adda0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the additions. Do you want to request anybody to (re)review the changes before merging?

@vhavlena
Copy link
Collaborator Author

I think we can merge it.

@Adda0 Adda0 merged commit b5527ca into devel Jan 19, 2024
20 checks passed
@Adda0 Adda0 deleted the readme-update branch January 19, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jurajsic jurajsic jurajsic approved these changes

@Adda0 Adda0 Adda0 approved these changes

@kilohsakul kilohsakul Awaiting requested review from kilohsakul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vhavlena @Adda0 @jurajsic