Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle interrupt correctly #30

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

sorawee
Copy link

@sorawee sorawee commented Sep 1, 2023

This commit fixes the problem where an interrupt will not kill a solver spawn by Picus, causing many solvers to be run concurrently in the background. Since the fix needs to be applied to three files that communicate with cvc5, Z3, and cvc4, I also took an opportunity to refactor them and unify them into one common file.

This commit fixes the problem where an interrupt will not kill a
solver spawn by Picus, causing many solvers to be run concurrently in
the background. Since the fix needs to be applied to three files
that communicate with cvc5, Z3, and cvc4, I also took an opportunity to
refactor them and unify them into one common file.
Copy link
Collaborator

@shankarapailoor shankarapailoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shankarapailoor shankarapailoor merged commit 2b28e47 into Veridise:main Sep 1, 2023
4 checks passed
@sorawee sorawee deleted the fix-interrupt branch September 1, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants