fix: speed up variable extractions #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior this commit, the variables are repeatedly appended at the back of a list, causing quadratic running time. Since ordering doesn't matter, this commit makes it appends to the front instead. Note that the algorithm overall is still potentially quadratic. A proper fix needs to changes the interface significantly to introduce an additional accumulator. This commit simply makes a minimal fix for the immediate issue that we are having, which causes CompConstant to get stuck.
| @@ -286,12 +241,7 @@ | |||
| ; define internal function | |||
There was a problem hiding this comment.
These comments feel useless to me. Let's instead describe the purpose of the internal function or just remove the comment entirely.
shankarapailoor
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior this commit, the variables are repeatedly appended at the back of a list, causing quadratic running time. Since ordering doesn't matter, this commit makes it appends to the front instead.
Note that the algorithm overall is still potentially quadratic. A proper fix needs to changes the interface significantly to introduce an additional accumulator. This commit simply makes a minimal fix for the immediate issue that we are having,
which causes CompConstant to get stuck.