Parser: only warn for implicitly-unsigned integer literals for base 10

Vexu · Oct 5, 2024 · 7ed4cb0 · 7ed4cb0
1 parent a824a68
commit 7ed4cb0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/aro/Parser.zig b/src/aro/Parser.zig
@@ -8506,7 +8506,7 @@ fn fixedSizeInt(p: *Parser, base: u8, buf: []const u8, suffix: NumberSuffix, tok
         return res;
     }
     const interned_val = try Value.int(val, p.comp);
-    if (suffix.isSignedInteger()) {
+    if (suffix.isSignedInteger() and base == 10) {
         const max_int = try Value.maxInt(p.comp.types.intmax, p.comp);
         if (interned_val.compare(.gt, max_int, p.comp)) {
             try p.errTok(.implicitly_unsigned_literal, tok_i);

diff --git a/test/cases/implicitly unsigned literal.c b/test/cases/implicitly unsigned literal.c
@@ -1,5 +1,6 @@
 _Static_assert(-9223372036854775808LL > 0, "lhs should be unsigned");
 long long x = 9223372036854775808LL;
+_Static_assert(0xFFFFFFFFFFFFFFFF == 0xFFFFFFFFFFFFFFFE + 1, "");
 
 #define EXPECTED_ERRORS \
 	"implicitly unsigned literal.c:1:17: warning: integer literal is too large to be represented in a signed integer type, interpreting as unsigned [-Wimplicitly-unsigned-literal]" \