Preprocessor: error instead of assert if include directive has no tokens

Vexu · Apr 19, 2024 · 94c3ee9 · 94c3ee9
1 parent 0d3a51d
commit 94c3ee9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/aro/Preprocessor.zig b/src/aro/Preprocessor.zig
@@ -1356,7 +1356,14 @@ fn stringify(pp: *Preprocessor, tokens: []const TokenWithExpansionLocs) !void {
 }
 
 fn reconstructIncludeString(pp: *Preprocessor, param_toks: []const TokenWithExpansionLocs, embed_args: ?*[]const TokenWithExpansionLocs, first: TokenWithExpansionLocs) !?[]const u8 {
-    assert(param_toks.len != 0);
+    if (param_toks.len == 0) {
+        try pp.comp.addDiagnostic(.{
+            .tag = .expected_filename,
+            .loc = first.loc,
+        }, first.expansionSlice());
+        return null;
+    }
+
     const char_top = pp.char_buf.items.len;
     defer pp.char_buf.items.len = char_top;
 

diff --git a/test/cases/include pragma.c b/test/cases/include pragma.c
@@ -0,0 +1,4 @@
+#include _Pragma("once")
+
+#define EXPECTED_ERRORS "include pragma.c:1:10: error: expected \"FILENAME\" or <FILENAME>" \
+
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,4 @@
		#include _Pragma("once")

		#define EXPECTED_ERRORS "include pragma.c:1:10: error: expected \"FILENAME\" or <FILENAME>" \