Attribute: apply malloc attribute

Vexu · Mar 22, 2024 · c6ce307 · c6ce307
1 parent 9cfb6dc
commit c6ce307
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/aro/Attribute.zig b/src/aro/Attribute.zig
@@ -896,6 +896,13 @@ pub fn applyFunctionAttributes(p: *Parser, ty: Type, attr_buf_start: usize) !Typ
                 else => try p.errStr(.callconv_not_supported, tok, p.tok_ids[tok].lexeme().?),
             },
         },
+        .malloc => {
+            if (base_ty.returnType().isPtr()) {
+                try p.attr_application_buf.append(p.gpa, attr);
+            } else {
+                try ignoredAttrErr(p, tok, attr.tag, "functions that do not return pointers");
+            }
+        },
         .access,
         .alloc_align,
         .alloc_size,
@@ -908,7 +915,6 @@ pub fn applyFunctionAttributes(p: *Parser, ty: Type, attr_buf_start: usize) !Typ
         .ifunc,
         .interrupt,
         .interrupt_handler,
-        .malloc,
         .no_address_safety_analysis,
         .no_icf,
         .no_instrument_function,

diff --git a/test/cases/ignored attributes.c b/test/cases/ignored attributes.c
@@ -0,0 +1,5 @@
+__attribute__((malloc)) int  foo(void);
+__attribute__((malloc)) int *bar(void);
+
+#define EXPECTED_ERRORS "ignored attributes.c:1:16: warning: attribute 'malloc' ignored on functions that do not return pointers [-Wignored-attributes]" \
+