Type: old & new style function types can be equal if there are no par…

…ameters
Vexu · Nov 27, 2023 · efed229 · efed229
1 parent 4306589
commit efed229
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/aro/Type.zig b/src/aro/Type.zig
@@ -105,6 +105,7 @@ pub const Func = struct {
     fn eql(a: *const Func, b: *const Func, a_spec: Specifier, b_spec: Specifier, comp: *const Compilation) bool {
         // return type cannot have qualifiers
         if (!a.return_type.eql(b.return_type, comp, false)) return false;
+        if (a.params.len == 0 and b.params.len == 0) return true;
 
         if (a.params.len != b.params.len) {
             if (a_spec == .old_style_func or b_spec == .old_style_func) {

diff --git a/test/cases/redefinitions.c b/test/cases/redefinitions.c
@@ -85,6 +85,12 @@ int f4(int);
 int f5(int (*)(), double (*)[3]);
 int f5(int (*)(char), double (*)[]); // not compatible since char undergoes default argument promotion
 
+void f6();
+void f6(void) {}
+
+void f7(void);
+void f7() {}
+
 #define EXPECTED_ERRORS "redefinitions.c:4:5: error: redefinition of 'foo' as different kind of symbol" \
     "redefinitions.c:1:5: note: previous definition is here" \
     "redefinitions.c:5:5: error: redefinition of 'foo' as different kind of symbol" \