Assembly statement parsing #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehaas
commented
Aug 30, 2023
ehaas
commented
Aug 30, 2023
Vexu
approved these changes
Aug 31, 2023
Also rearrange some code to make the grammar easier to specify
ehaas
force-pushed
the
assembly-statement
branch
from
99b83bd
to
9393812
Compare
|
Added grammar comments, let me know if they should be more detailed - right now it's just the syntax; would it be helpful to explain e.g. that the first asmOperand is inputs, second is outputs, etc.? |
|
The grammar combined with reading the comments in the function is good enough for me and gnu has this documented online if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary thing here is adding support for GNU inline assembly statements. Currently it just parses the statement, no attempt is made to validate it. There's also the question of how it should be added to the AST - any thought about how to structure that? There's a lot of data - the assembly template string,
volatileflag, inputs, output, and label expressions, constraints, clobbers...