Type: improve type equality checking #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Arrays with same child type are compatible if at least one array is incomplete 2) Functions must both have or both not have ellipses to be compatible 3) A function with no prototype is compatible with a function with a parameter list if none of the named parameter types undergo default argument promotion and the return type is compatible
Vexu
approved these changes
Oct 24, 2023
| @@ -9,5 +9,4 @@ int arr[3]; // TODO should make the error go away | |||
| #define EXPECTED_ERRORS \ | |||
| "tentative array.c:1:5: warning: tentative array definition assumed to have one element" \ | |||
| "tentative array.c:3:16: error: invalid application of 'sizeof' to an incomplete type 'int []'" \ | |||
| "tentative array.c:5:5: error: redefinition of 'arr' with a different type" \ | |||
| "tentative array.c:1:5: note: previous definition is here" \ | |||
|
|
|||
There was a problem hiding this comment.
Should also remove the TODO and SKIPPED_TESTS.
There was a problem hiding this comment.
For this one the warning: tentative array definition assumed to have one element should not happen since the definition is later completed. I think we'd have to do something similar to what we do for tentative_defs in the Parser since we don't want to issue the warning until we're done and have determined the definition is incomplete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to figure these out by reading the standard but it's pretty dry.
Functions in C11 6.7.6.3.15 (too long to paste)
Arrays in C11 6.7.6.2.6: "For two array types to be compatible, both shall have compatible element types, and if both size specifiers are present, and are integer constant expressions, then both size specifiers shall have the same constant value"
Briefly,