Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation: check for embedded null bytes in path for has_include #586

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Compilation: check for embedded null bytes in path for has_include #586

merged 1 commit into from
Nov 28, 2023

Conversation

ehaas
Copy link
Collaborator

@ehaas ehaas commented Nov 27, 2023

Prevents a crash caused by embedded NUL bytes

@ehaas
Copy link
Collaborator Author

ehaas commented Nov 27, 2023

This makes it think that __has_include.c is a binary file - I can move it into its own file or just leave the test out if you want.

@Vexu
Copy link
Owner

Vexu commented Nov 27, 2023

Should this also be done for __has_embed?

This makes it think that __has_include.c is a binary file

You can change that with .gitattributes.

@ehaas
Copy link
Collaborator Author

ehaas commented Nov 27, 2023

__has_embed uses a different path, I wasn't able to get it to crash on latest master.

@Vexu Vexu force-pushed the has-include branch 2 times, most recently from dbfb7eb to 070f3ba Compare November 28, 2023 11:54
@Vexu
Copy link
Owner

Vexu commented Nov 28, 2023

Hmm, locally git shows a regular diff but GitHub wont. This can probably go without a test...

@Vexu Vexu merged commit 521b2f6 into Vexu:master Nov 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehaas @Vexu