fix: spurious unsigned overflows #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vexu
requested changes
Nov 29, 2023
|
Can you add the check for subtraction and division as well? |
eightfilms
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #581
We add signedness checks prior to doing an
errOverflow, + add tests (i've also confirmed that 0x80000000 * 2 erroneously triggers an overflow warning).Given this source:
It seems like it might be fair to check that both LHS and RHS are not unsigned, in order for the overflow warning to show.
@ehaas re: your suggestion to look at
fn add()inValue.zig, it seems like enumerations and ++ also relies on that - so I did these checks up one level instead, if this is fair?