Reduce the size of the DAFSA nodes for names #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Names can use 32 bits per DAFSA node instead of the 64 bits needed for the builtins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just something random I noticed: names can use 32 bits per DAFSA node instead of the 64 bits needed for the builtins.
I haven't done any performance/size comparisons but it should make for a smaller and faster names DAFSA.
Just for context, the absolute minimum number of bits for a names DAFSA node as it currently exists would be
22: 5 forcharsince it only includes_anda-z[but if it was stored asu5then it'd need a+ '_'transformation to get the actual ASCII value], 2 for the end_of_word/end_of_list bools, 5 fornumbersince the max value is 24, and 10 forchild_indexsince the max value is 621)