Parser: improve return detection for switch statments #620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #619
The switch statement was not handled correctly by nodeIsNoreturn, since break and continue returned .yes like return_stmt that caused that it was treated like a return from the function instead of just exiting the switch statement.
Also added handling for the default statement for a simple switch+default, the case statement is not handled for now because it requires more complex reasoning when combined with multiple cases or with an default statement inside a compound statement, so it return the default .no value.
And changed the check of compound_stmt to try to find a statement with a return instead of just looking the last one.
Since switch_stmt no longer return .complex i have remove it for now, since if_then_else_stmt will no longer propagate it and no other statement use it.
Because the nodeIsNoreturn function is also used to detect the cases of unreachable code, changing break and continue cause the analysis to no longer detect this type of case:
This is still not a complete solution since loop statements are not handled correctly, generating a "does not return a value" warning: