Parser: implement stdckdint.h #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we move |
Vexu
approved these changes
Feb 11, 2024
| @@ -4794,7 +4794,11 @@ const CallExpr = union(enum) { | |||
| Builtin.tagFromName("__va_start").?, | |||
| Builtin.tagFromName("va_start").?, | |||
| => arg_idx != 1, | |||
| Builtin.tagFromName("__builtin_complex").? => false, | |||
| Builtin.tagFromName("__builtin_complex").?, | |||
There was a problem hiding this comment.
Are we sure these are memoized properly? Getting a bit worried about something like ziglang/zig#7948 happening here
There was a problem hiding this comment.
I'm not sure how to know if that's happening - I had to up the eval branch quote for checkVarArg - is that why you ask?
There was a problem hiding this comment.
is that why you ask?
No just because there are so many calls now. I checked with @compileLog and they are getting memoized properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #578