Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make qual_handling enum for canonicalize() public #649

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

f-cozzocrea
Copy link
Contributor

Applies the change made to the aro source in ziglang/zig#19227.

@Vexu
Copy link
Owner

Vexu commented Mar 19, 2024

Looks like the new pointer safety checks found a bug, I'll look into it tomorrow.

@ehaas
Copy link
Collaborator

ehaas commented Mar 19, 2024

Repro:

const std = @import("std");
test "Allocation failures" {
    const Test = struct {
        fn testOne(allocator: std.mem.Allocator) !void {
            var map: std.StringHashMapUnmanaged(void) = .{};
            defer map.deinit(allocator);

            _ = try map.getOrPut(allocator, "hello");
        }
    };

    try std.testing.checkAllAllocationFailures(std.testing.allocator, Test.testOne, .{});
}

@ehaas
Copy link
Collaborator

ehaas commented Mar 19, 2024

Upstream bug report ziglang/zig#19358

@f-cozzocrea f-cozzocrea force-pushed the pub-qual-handling-enum branch from bd6d22e to c53159f Compare March 21, 2024 19:09
@Vexu Vexu force-pushed the pub-qual-handling-enum branch from c53159f to 552fef1 Compare March 22, 2024 05:57
@Vexu Vexu merged commit d0ade99 into Vexu:master Mar 22, 2024
3 checks passed
@f-cozzocrea f-cozzocrea deleted the pub-qual-handling-enum branch March 22, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants