emulate chosen compiler in integer literal promotion #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vexu
reviewed
Jul 15, 2024
src/aro/Diagnostics/messages.def
Outdated
Comment on lines
1302
to
1305
| implicitly_unsigned_literal_gcc | ||
| .msg = "integer constant is so large that it is unsigned" | ||
| .kind = .warning | ||
|
|
There was a problem hiding this comment.
I don't think we need to emulate differently worded diagnostics too.
src/aro/Parser.zig
Outdated
| @@ -8448,7 +8448,7 @@ fn fixedSizeInt(p: *Parser, base: u8, buf: []const u8, suffix: NumberSuffix, tok | |||
| const max_int = try Value.maxInt(res.ty, p.comp); | |||
| if (interned_val.compare(.lte, max_int, p.comp)) break; | |||
| } else { | |||
| res.ty = .{ .specifier = .ulong_long }; | |||
| res.ty = .{ .specifier = if (p.comp.langopts.emulate == .gcc) .int128 else .ulong_long }; | |||
There was a problem hiding this comment.
This needs to check that the target supports __int128 with target_utils.hasFloat128.
There was a problem hiding this comment.
Sorry, target_utils.hasInt128. It looks like there is a helper for hasFloat128 in Compilation, you could add the same for hasInt128.
|
@Vexu could you review changes now if you have a chance? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #690