Eliminate dead architecture tags #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrp
approved these changes
Jul 23, 2024
Vexu
reviewed
Jul 23, 2024
src/aro/target.zig
Outdated
| .linux => "linux", | ||
| .lv2 => "lv2", | ||
| .ps3 => "ps3", |
There was a problem hiding this comment.
The LLVM name shouldn't be changed.
There was a problem hiding this comment.
Why so? It has been changed here https://github.com/ziglang/zig/pull/20708/files#diff-73b15ac9aed4b9aca85583d8caa883b2a5211a63b411ae6ef088a6d8b92156f6L671
There was a problem hiding this comment.
not sure what did you mean
There was a problem hiding this comment.
Oh, I'm sorry. Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see ziglang/zig#20708
ziglang/zig#20402