Check argument size on static array parameters #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vexu
requested changes
Aug 4, 2024
src/aro/Parser.zig
Outdated
| @@ -7683,6 +7684,18 @@ fn callExpr(p: *Parser, lhs: Result) Error!Result { | |||
| continue; | |||
| } | |||
| const p_ty = params[arg_count].ty; | |||
| if (p_ty.statically_sized_array) { | |||
| if (arg.ty.data == .array and arg.ty.data.array.*.len < p_ty.data.array.*.len) { | |||
There was a problem hiding this comment.
This should use arrayLen instead of making the union tagged.
| .expected = @intCast(arg.ty.data.array.*.len), | ||
| .actual = @intCast(p_ty.data.array.*.len), | ||
| } }; | ||
| try p.errExtra(.array_argument_too_small, param_tok, extra); |
There was a problem hiding this comment.
Clang also adds a callee declares array parameter as static here note. You should be able to do the same with params[arg_count].name_tok.
src/aro/Type.zig
Outdated
| @@ -425,6 +425,7 @@ data: union { | |||
| specifier: Specifier, | |||
| qual: Qualifiers = .{}, | |||
| decayed: bool = false, | |||
| statically_sized_array: bool = false, | |||
|
@Vexu all the desired changes have been made |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #349