UI fixes, start with mixins

src/main/java/de/florianmichael/viafabricplus/injection/mixin/fixes/minecraft/MixinPlayerListEntry.java

@@ -32,13 +32,14 @@
 import org.spongepowered.asm.mixin.injection.At;
 import org.spongepowered.asm.mixin.injection.Redirect;
 
+import java.util.Optional;
 import java.util.concurrent.CompletableFuture;
 
 @Mixin(PlayerListEntry.class)
 public abstract class MixinPlayerListEntry {
 
     @Redirect(method = "texturesSupplier", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/texture/PlayerSkinProvider;fetchSkinTextures(Lcom/mojang/authlib/GameProfile;)Ljava/util/concurrent/CompletableFuture;"))
-    private static CompletableFuture<SkinTextures> fetchGameProfileProperties(PlayerSkinProvider instance, GameProfile profile) {
+    private static CompletableFuture<Optional<SkinTextures>> fetchGameProfileProperties(PlayerSkinProvider instance, GameProfile profile) {
         if (ProtocolTranslator.getTargetVersion().olderThanOrEqualTo(ProtocolVersion.v1_20) && !profile.getProperties().containsKey("textures")) {
             return CompletableFuture.supplyAsync(() -> {
                 final ProfileResult profileResult = MinecraftClient.getInstance().getSessionService().fetchProfile(profile.getId(), true);

src/main/java/de/florianmichael/viafabricplus/screen/VFPList.java

@@ -30,7 +30,7 @@
  * Wrapper class for {@link AlwaysSelectedEntryListWidget} including the following features:
  * <ul>
  *     <li>Changing the constructor arguments to be more readable and customizable</li>
- *     <li>Adds {@link #initScrollAmount(double)} to save the scroll state after closing the screen, requires static tracking by the implementation</li>
+ *     <li>Adds {@link #initScrollY(double)} to save the scroll state after closing the screen, requires static tracking by the implementation</li>
  *     <li>Removes the selection box</li>
  * </ul>
  *
@@ -43,17 +43,17 @@ public VFPList(MinecraftClient minecraftClient, int width, int height, int top,
         super(minecraftClient, width, height - top - bottom, top, entryHeight);
     }
 
-    public void initScrollAmount(final double amount) {
+    public void initScrollY(final double scrollY) {
         // Needs calling last in init to have data loaded before setting scroll amount
         if (GeneralSettings.global().saveScrollPositionInSlotScreens.getValue()) {
-            this.setScrollAmount(amount);
+            this.setScrollY(scrollY);
         }
     }
 
     @Override
-    public void setScrollAmountOnly(double amount) {
-        super.setScrollAmountOnly(amount);
-        updateSlotAmount(getScrollAmount()); // Ensure value is clamped
+    public void setScrollY(double scrollY) {
+        super.setScrollY(scrollY);
+        updateSlotAmount(getScrollY()); // Ensure value is clamped
     }
 
     @Override

src/main/java/de/florianmichael/viafabricplus/screen/base/ProtocolSelectionScreen.java

@@ -65,7 +65,7 @@ public SlotList(MinecraftClient minecraftClient, int width, int height, int top,
             super(minecraftClient, width, height, top, bottom, entryHeight);
 
             ProtocolVersionList.getProtocolsNewToOld().stream().map(ProtocolSlot::new).forEach(this::addEntry);
-            initScrollAmount(scrollAmount);
+            initScrollY(scrollAmount);
         }
 
         @Override

src/main/java/de/florianmichael/viafabricplus/screen/classic4j/BetaCraftScreen.java

@@ -90,7 +90,7 @@ public SlotList(MinecraftClient minecraftClient, int width, int height, int top,
                 }
             }
 
-            initScrollAmount(scrollAmount);
+            initScrollY(scrollAmount);
         }
 
         @Override

src/main/java/de/florianmichael/viafabricplus/screen/classic4j/ClassiCubeServerListScreen.java

@@ -97,7 +97,7 @@ public SlotList(MinecraftClient minecraftClient, int width, int height, int top,
             super(minecraftClient, width, height, top, bottom, entryHeight);
 
             SERVER_LIST.forEach(serverInfo -> this.addEntry(new ServerSlot(serverInfo)));
-            initScrollAmount(scrollAmount);
+            initScrollY(scrollAmount);
         }
 
         @Override

src/main/java/de/florianmichael/viafabricplus/screen/realms/BedrockRealmsScreen.java

@@ -166,7 +166,7 @@ public SlotList(MinecraftClient minecraftClient, int width, int height, int top,
             for (RealmsWorld realmsWorld : BedrockRealmsScreen.this.realmsWorlds) {
                 this.addEntry(new SlotEntry(this, realmsWorld));
             }
-            initScrollAmount(scrollAmount);
+            initScrollY(scrollAmount);
         }
 
         @Override

src/main/java/de/florianmichael/viafabricplus/screen/settings/SettingsScreen.java

@@ -56,7 +56,7 @@ public SlotList(MinecraftClient minecraftClient, int width, int height, int top,
                     this.addEntry(setting.makeSettingRenderer());
                 }
             }
-            initScrollAmount(scrollAmount);
+            initScrollY(scrollAmount);
         }
 
         @Override