Remove wrong injection causing sprinting to never reset in <= 1.14.4

Closes #577
ViaVersion · Oct 11, 2024 · ed73cde · ed73cde
1 parent 7394c86
commit ed73cde
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 6 deletions.
diff --git a/docs/MAINTAINING.md b/docs/MAINTAINING.md
@@ -12,7 +12,6 @@ These steps are the usual process for updating ViaFabricPlus to a new version of
    As well as the versions in the `dependencies` block in the `build.gradle` file.
 2. Update the `NATIVE_VERSION` field in the ProtocolTranslator class to the new version
 3. Check all mixins in the injection package if they still apply correctly, here is a list of some critical ones:
-    - `MixinClientPlayerEntity#removeBl8Boolean`
     - `MixinClientWorld#tickEntity` and `MixinClientWorld#tickPassenger`
     - `MixinPlayer#getBlockBreakingSpeed`
 4. Decompile the game source code with the tool of your choice.

diff --git a/...michael/viafabricplus/injection/mixin/fixes/minecraft/entity/MixinClientPlayerEntity.java b/...michael/viafabricplus/injection/mixin/fixes/minecraft/entity/MixinClientPlayerEntity.java
@@ -145,11 +145,6 @@ private boolean allowElytraInVehicle(ClientPlayerEntity instance) {
         return ProtocolTranslator.getTargetVersion().newerThan(ProtocolVersion.v1_14_4) && instance.hasVehicle();
     }
 
-    @ModifyVariable(method = "tickMovement", at = @At(value = "LOAD", ordinal = 4), ordinal = 4)
-    private boolean removeBl8Boolean(boolean value) {
-        return ProtocolTranslator.getTargetVersion().newerThan(ProtocolVersion.v1_14_4) && value;
-    }
-
     @Inject(method = "tickMovement()V",
             slice = @Slice(from = @At(value = "INVOKE", target = "Lnet/minecraft/client/network/ClientPlayerEntity;isCamera()Z")),
             at = @At(value = "FIELD", target = "Lnet/minecraft/client/input/Input;sneaking:Z", ordinal = 0))