Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor "enableSwordAnimation" to "swordBlockingAnimation" #639

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

lowercasebtw
Copy link
Collaborator

@lowercasebtw lowercasebtw commented Dec 2, 2024

Renames "enableSwordAnimation" to "swordBlockingAnimation" to matching naming scheme/usage & adds check to not apply rotations if item is of shield, to fix issue in 1.9+ when the setting is enabled. 1.21.4 does this.

@FlorianMichael FlorianMichael merged commit 3d7ee17 into ViaVersion:main Dec 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants