Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow formatting of const pointers #70

Closed
wants to merge 1 commit into from

Conversation

dns13
Copy link

@dns13 dns13 commented Oct 11, 2023

This pull request fixes #69

@dns13 dns13 changed the title Fix #69 Allow formatting of const pointers Oct 11, 2023
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (423edc9) 99.40% compared to head (04ea0de) 99.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage   99.40%   99.40%           
=======================================
  Files          56       56           
  Lines        5866     5866           
=======================================
  Hits         5831     5831           
  Misses         35       35           
Files Coverage Δ
include/emio/detail/format/formatter.hpp 98.72% <ø> (ø)
include/emio/formatter.hpp 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Viatorus
Copy link
Owner

Viatorus commented Oct 11, 2023

Thank you for your contribution! I toke your idea and improved it in #72.

@Viatorus Viatorus closed this Oct 11, 2023
@dns13
Copy link
Author

dns13 commented Oct 11, 2023

Great thank you. That's a better solution, volatile pointers were the next issue I would have stepped on.

@dns13 dns13 deleted the 69-cant-format-const-pointers branch October 12, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't format const pointers
3 participants