Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: derived fields settings implements #231

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

090809
Copy link
Contributor

@090809 090809 commented Feb 3, 2025

Closes #202

Implemented with Loki derived fields (some code of this already exists, added only configuration screen)

Loori-R
Loori-R previously approved these changes Feb 10, 2025
Copy link
Contributor

@Loori-R Loori-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM!

@Loori-R Loori-R requested a review from dmitryk-dk February 10, 2025 11:39
dmitryk-dk
dmitryk-dk previously approved these changes Feb 10, 2025
Copy link
Contributor

@dmitryk-dk dmitryk-dk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dmitryk-dk
Copy link
Contributor

Hi @090809 ! Could you please sign your commit and update CHANGELOG with your changes, please?

We want to merge your updates but can't do it because your commit is unsigned

@090809 090809 dismissed stale reviews from dmitryk-dk and Loori-R via 4c104a9 February 12, 2025 13:27
@090809 090809 force-pushed the feat/derived-fields branch from 4c104a9 to c4c5314 Compare February 12, 2025 13:30
@090809
Copy link
Contributor Author

090809 commented Feb 12, 2025

Hi @dmitryk-dk
Signed-off commits, added changelog

Copy link
Contributor

@dmitryk-dk dmitryk-dk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dmitryk-dk dmitryk-dk merged commit 2fda493 into VictoriaMetrics:main Feb 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: derived fields!
3 participants